Discussion:
[Bug 233004] ix0 at 12-BETA2: can not turn off RXCSUM/RXCSUM_IPV6
(too old to reply)
b***@freebsd.org
2018-11-05 21:15:42 UTC
Permalink
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233004

Lev A. Serebryakov <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Assignee|***@FreeBSD.org |***@FreeBSD.org
--
You are receiving this mail because:
You are the assignee for the bug.
b***@freebsd.org
2018-11-06 18:32:57 UTC
Permalink
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233004

--- Comment #1 from Stephen Hurd <***@FreeBSD.org> ---
What options are set by on that card when you try disabling rxcsum? Does the
link go down then back up when failing to disable rxcsum?
--
You are receiving this mail because:
You are the assignee for the bug.
b***@freebsd.org
2018-11-06 19:58:42 UTC
Permalink
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233004

--- Comment #2 from Lev A. Serebryakov <***@FreeBSD.org> ---
(In reply to Stephen Hurd from comment #1)
Nothing changes:

root@:/tmp # ifconfig ix0
ix0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500

options=e53fbb<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,JUMBO_MTU,VLAN_HWCSUM,TSO4,TSO6,LRO,WOL_UCAST,WOL_MCAST,WOL_MAGIC,VLAN_HWFILTER,VLAN_HWTSO,RXCSUM_IPV6,TXCSUM_IPV6>
ether 90:e2:ba:a3:c0:90
inet 192.168.10.2 netmask 0xffffff00 broadcast 192.168.10.255
media: Ethernet autoselect (10Gbase-SR <full-duplex,rxpause,txpause>)
status: active
nd6 options=29<PERFORMNUD,IFDISABLED,AUTO_LINKLOCAL>
root@:/tmp # ifconfig ix0 -rxcsum
root@:/tmp # ifconfig ix0
ix0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500

options=e53fbb<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,JUMBO_MTU,VLAN_HWCSUM,TSO4,TSO6,LRO,WOL_UCAST,WOL_MCAST,WOL_MAGIC,VLAN_HWFILTER,VLAN_HWTSO,RXCSUM_IPV6,TXCSUM_IPV6>
ether 90:e2:ba:a3:c0:90
inet 192.168.10.2 netmask 0xffffff00 broadcast 192.168.10.255
media: Ethernet autoselect (10Gbase-SR <full-duplex,rxpause,txpause>)
status: active
nd6 options=29<PERFORMNUD,IFDISABLED,AUTO_LINKLOCAL>
root@:/tmp # ifconfig ix0 -rxcsum6
root@:/tmp # ifconfig ix0
ix0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500

options=e53fbb<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,JUMBO_MTU,VLAN_HWCSUM,TSO4,TSO6,LRO,WOL_UCAST,WOL_MCAST,WOL_MAGIC,VLAN_HWFILTER,VLAN_HWTSO,RXCSUM_IPV6,TXCSUM_IPV6>
ether 90:e2:ba:a3:c0:90
inet 192.168.10.2 netmask 0xffffff00 broadcast 192.168.10.255
media: Ethernet autoselect (10Gbase-SR <full-duplex,rxpause,txpause>)
status: active
nd6 options=29<PERFORMNUD,IFDISABLED,AUTO_LINKLOCAL>

Interface DOESN'T change state (up/down) (no "ix0: link state changed to
DOWN/UP" on console or in dmesg).

When I turn on/turn off txcsum and/or txcsum6 interface goes via down/up
sequence according to console/dmesg. And these options work :-)
--
You are receiving this mail because:
You are the assignee for the bug.
b***@freebsd.org
2018-11-06 20:05:13 UTC
Permalink
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233004

--- Comment #3 from Stephen Hurd <***@FreeBSD.org> ---
Does -rxcsum6 disable both rxcsum and rxcsum6 by any chance? Or does it also
have no effect?

I should have my system with an ix in it up in a couple hours, so I should be
able to test/fix this tonight.
--
You are receiving this mail because:
You are the assignee for the bug.
b***@freebsd.org
2018-11-06 20:06:05 UTC
Permalink
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233004

--- Comment #4 from Stephen Hurd <***@FreeBSD.org> ---
Never mind, I see it. Thanks!
--
You are receiving this mail because:
You are the assignee for the bug.
b***@freebsd.org
2018-11-06 20:40:03 UTC
Permalink
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233004

--- Comment #5 from Lev A. Serebryakov <***@FreeBSD.org> ---
I've checked 11.2-RELEASE on exactly same system (booted it from 11.2
installation media) and 11.2 doesn't have this problem.
--
You are receiving this mail because:
You are the assignee for the bug.
b***@freebsd.org
2018-11-06 20:40:21 UTC
Permalink
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233004

--- Comment #6 from Lev A. Serebryakov <***@FreeBSD.org> ---
And 11.2 doesn't cycle interface down/up :-)
--
You are receiving this mail because:
You are the assignee for the bug.
b***@freebsd.org
2018-11-06 21:14:29 UTC
Permalink
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233004

Jeff Pieper <***@intel.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@intel.com

--- Comment #7 from Jeff Pieper <***@intel.com> ---
The difference is that with the driver in 12.0-BETA, that is controlled by
iflib and with the driver in 11.2 it is not.
--
You are receiving this mail because:
You are the assignee for the bug.
b***@freebsd.org
2018-11-06 21:47:24 UTC
Permalink
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233004

--- Comment #8 from Lev A. Serebryakov <***@FreeBSD.org> ---
(In reply to Jeff Pieper from comment #7)
Yes, I understand this.
I hope to have feature parity between old and new at least :-)
--
You are receiving this mail because:
You are the assignee for the bug.
b***@freebsd.org
2018-11-07 05:07:20 UTC
Permalink
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233004

--- Comment #9 from Stephen Hurd <***@FreeBSD.org> ---
The issue should be fixed by https://reviews.freebsd.org/D17881

r338838 attempted to fix issues with rxcsum and rxcsum6.
However, the rxcsum bits were set as though if_setcapenablebit() was
being called, not if_togglecapenable() which is in use. As a result,
it was not possible to disable rxcsum in various cases.
--
You are receiving this mail because:
You are the assignee for the bug.
b***@freebsd.org
2018-11-07 05:07:37 UTC
Permalink
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233004

Stephen Hurd <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Assignee|***@FreeBSD.org |***@FreeBSD.org
Status|New |In Progress
--
You are receiving this mail because:
You are the assignee for the bug.
b***@freebsd.org
2018-11-07 15:01:24 UTC
Permalink
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233004

Rodney W. Grimes <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@FreeBSD.org
--
You are receiving this mail because:
You are on the CC list for the bug.
b***@freebsd.org
2018-11-07 19:31:53 UTC
Permalink
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233004

--- Comment #10 from commit-***@freebsd.org ---
A commit references this bug:

Author: shurd
Date: Wed Nov 7 19:31:49 UTC 2018
New revision: 340236
URL: https://svnweb.freebsd.org/changeset/base/340236

Log:
Fix rxcsum issue introduced in r338838

r338838 attempted to fix issues with rxcsum and rxcsum6.
However, the rxcsum bits were set as though if_setcapenablebit() was
being called, not if_togglecapenable() which is in use. As a result,
it was not possible to disable rxcsum when rxcsum6 was supported.

PR: 233004
Reported by: lev
Reviewed by: lev
MFC after: 3 days
Sponsored by: Limelight Networks
Differential Revision: https://reviews.freebsd.org/D17881

Changes:
head/sys/net/iflib.c
--
You are receiving this mail because:
You are on the CC list for the bug.
b***@freebsd.org
2018-11-09 22:21:18 UTC
Permalink
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233004

Stephen Hurd <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|In Progress |Closed
Resolution|--- |FIXED
--
You are receiving this mail because:
You are on the CC list for the bug.
b***@freebsd.org
2018-11-12 16:09:08 UTC
Permalink
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233004

--- Comment #11 from commit-***@freebsd.org ---
A commit references this bug:

Author: shurd
Date: Mon Nov 12 16:08:14 UTC 2018
New revision: 340365
URL: https://svnweb.freebsd.org/changeset/base/340365

Log:
MFC r340236:

Fix rxcsum issue introduced in r338838

r338838 attempted to fix issues with rxcsum and rxcsum6.
However, the rxcsum bits were set as though if_setcapenablebit() was
being called, not if_togglecapenable() which is in use. As a result,
it was not possible to disable rxcsum when rxcsum6 was supported.

PR: 233004
Reported by: lev
Reviewed by: lev
Approved by: re (kib)
Sponsored by: Limelight Networks
Differential Revision: https://reviews.freebsd.org/D17881

Changes:
_U stable/12/
stable/12/sys/net/iflib.c
--
You are receiving this mail because:
You are on the CC list for the bug.
b***@freebsd.org
2018-11-19 08:49:55 UTC
Permalink
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233004

Kubilay Kocak <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Flags| |mfc-stable12+
--
You are receiving this mail because:
You are on the CC list for the bug.
Loading...