[Bug 255430] ng_bridge don't sends broadcast packet to first found link in case of error in other links

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255430

Mark Linimon <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Assignee|***@FreeBSD.org |***@FreeBSD.org

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255430

Lutz Donnerhacke <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@FreeBSD.org
Assignee|***@FreeBSD.org |***@FreeBSD.org

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255430

Rodney W. Grimes <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@FreeBSD.org

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255430

--- Comment #2 from Dancho Penev <***@hotmail.com> ---
I don't see any change in patch semantics, it's just rephrasing so it should
works. Will provide feedback when have time to test your patch.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255430

--- Comment #3 from Dancho Penev <***@hotmail.com> ---
Made some basic testing with the new patch, no issues were observed so far.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255430

--- Comment #4 from Lutz Donnerhacke <***@FreeBSD.org> ---
I'll wait for reviews from others before commiting it.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255430

--- Comment #5 from commit-***@FreeBSD.org ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=a56e5ad6903037861457da754574b4903dcb0e7e

commit a56e5ad6903037861457da754574b4903dcb0e7e
Author: Lutz Donnerhacke <***@FreeBSD.org>
AuthorDate: 2021-04-27 07:49:50 +0000
Commit: Lutz Donnerhacke <***@FreeBSD.org>
CommitDate: 2021-05-13 19:49:20 +0000

netgraph/ng_bridge: Handle send errors during loop handling

If sending out a packet fails during the loop over all links, the
allocated memory is leaked and not all links receive a copy. This
patch fixes those problems, clarifies a premature abort of the loop,
and fixes a minory style(9) bug.

PR: 255430
Submitted by: Dancho Penev
Tested by: Dancho Penev
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D30008

sys/netgraph/ng_bridge.c | 55 ++++++++++++++++++++++++++----------------------
1 file changed, 30 insertions(+), 25 deletions(-)

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255430

Lutz Donnerhacke <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|In Progress |Closed

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255430

Kubilay Kocak <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |---
URL| |https://reviews.freebsd.org
| |/D30008
Flags| |mfc-stable13?,
| |mfc-stable12?
Status|Closed |In Progress

--- Comment #6 from Kubilay Kocak <***@FreeBSD.org> ---
^Triage: Re-open pending MFC

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255430

--- Comment #7 from commit-***@FreeBSD.org ---
A commit in branch stable/13 references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=e240dd0d502e5c6741007e6e8f9ac41a0e5c33cd

commit e240dd0d502e5c6741007e6e8f9ac41a0e5c33cd
Author: Lutz Donnerhacke <***@FreeBSD.org>
AuthorDate: 2021-04-27 07:49:50 +0000
Commit: Lutz Donnerhacke <***@FreeBSD.org>
CommitDate: 2021-05-20 05:52:21 +0000

netgraph/ng_bridge: Handle send errors during loop handling

If sending out a packet fails during the loop over all links, the
allocated memory is leaked and not all links receive a copy. This
patch fixes those problems, clarifies a premature abort of the loop,
and fixes a minory style(9) bug.

PR: 255430
Submitted by: Dancho Penev
Tested by: Dancho Penev
Differential Revision: https://reviews.freebsd.org/D30008

(cherry picked from commit a56e5ad6903037861457da754574b4903dcb0e7e)

sys/netgraph/ng_bridge.c | 55 ++++++++++++++++++++++++++----------------------
1 file changed, 30 insertions(+), 25 deletions(-)

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255430

--- Comment #8 from commit-***@FreeBSD.org ---
A commit in branch stable/12 references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=1165cafa0baee55a46459e4cf7c2573ca25a0a1c

commit 1165cafa0baee55a46459e4cf7c2573ca25a0a1c
Author: Lutz Donnerhacke <***@FreeBSD.org>
AuthorDate: 2021-04-27 07:49:50 +0000
Commit: Lutz Donnerhacke <***@FreeBSD.org>
CommitDate: 2021-05-20 05:58:30 +0000

netgraph/ng_bridge: Handle send errors during loop handling

If sending out a packet fails during the loop over all links, the
allocated memory is leaked and not all links receive a copy. This
patch fixes those problems, clarifies a premature abort of the loop,
and fixes a minory style(9) bug.

PR: 255430
Submitted by: Dancho Penev
Tested by: Dancho Penev
Differential Revision: https://reviews.freebsd.org/D30008

(cherry picked from commit a56e5ad6903037861457da754574b4903dcb0e7e)

sys/netgraph/ng_bridge.c | 57 ++++++++++++++++++++++++++----------------------
1 file changed, 31 insertions(+), 26 deletions(-)

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255430

Lutz Donnerhacke <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|In Progress |Closed
Resolution|--- |FIXED

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255430

Kubilay Kocak <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Flags|mfc-stable13?, |mfc-stable13+,
|mfc-stable12? |mfc-stable12+