[Bug 255388] [PATCH] Do not forward datagrams original from 169.254.0.0/16

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255388

Mark Linimon <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Assignee|***@FreeBSD.org |***@FreeBSD.org
CC|***@FreeBSD.org |

--- Comment #2 from Mark Linimon <***@FreeBSD.org> ---
^Triage: assign to mailing list. Note that original committer is no longer
working on FreeBSD.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255388

Kubilay Kocak <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Keywords|patch |needs-qa
Status|New |Open
URL| |https://reviews.freebsd.org
| |/D29968
Summary|[PATCH] Do not forward |netinet/ip_input.c: Do not
|datagrams original from |forward datagrams original
|169.254.0.0/16 |from 169.254.0.0/16

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255388

--- Comment #3 from commit-***@FreeBSD.org ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=3d846e48227e2e78c1e7b35145f57353ffda56ba

commit 3d846e48227e2e78c1e7b35145f57353ffda56ba
Author: Zhenlei Huang <***@gmail.com>
AuthorDate: 2021-05-18 20:51:37 +0000
Commit: Lutz Donnerhacke <***@FreeBSD.org>
CommitDate: 2021-05-18 20:59:46 +0000

Do not forward datagrams originated by link-local addresses

The current implement of ip_input() reject packets destined for
169.254.0.0/16, but not those original from 169.254.0.0/16 link-local
addresses.

Fix to fully respect RFC 3927 section 2.7.

PR: 255388
Reviewed by: donner, rgrimes, karels
MFC after: 1 month
Differential Revision: https://reviews.freebsd.org/D29968

sys/netinet/ip_input.c | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255388

--- Comment #4 from commit-***@FreeBSD.org ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=03b0505b8fe848f33f2f38fe89dd5538908c847e

commit 03b0505b8fe848f33f2f38fe89dd5538908c847e
Author: Zhenlei Huang <***@gmail.com>
AuthorDate: 2021-05-22 21:53:52 +0000
Commit: Lutz Donnerhacke <***@FreeBSD.org>
CommitDate: 2021-05-22 22:01:37 +0000

ip_forward: Restore RFC reference

Add RFC reference lost in 3d846e48227e2e78c1e7b35145f57353ffda56ba

PR: 255388
Reviewed By: rgrimes, donner, karels, marcus, emaste
MFC after: 27 days
Differential Revision: https://reviews.freebsd.org/D30374

sys/netinet/ip_input.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255388

Kubilay Kocak <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|Open |In Progress
Flags| |mfc-stable13?,
| |mfc-stable12?
Keywords|needs-qa |