Discussion:
[Bug 241954] netgraph fails on concurrent node rename
b***@freebsd.org
2021-05-02 20:04:54 UTC
Permalink
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241954

Lutz Donnerhacke <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|New |Open
CC| |***@FreeBSD.org
Assignee|***@FreeBSD.org |***@FreeBSD.org
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
b***@freebsd.org
2021-05-04 16:57:51 UTC
Permalink
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241954

--- Comment #2 from Lutz Donnerhacke <***@FreeBSD.org> ---
https://github.com/genneko/freebsd-vimage-jails/issues/2 describes the problem
in detail: ng_name_node() is called twice and does not recognize the rename to
the identical name. This might be solvable.
--
You are receiving this mail because:
You are on the CC list for the bug.
b***@freebsd.org
2021-05-04 19:29:36 UTC
Permalink
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241954

Lutz Donnerhacke <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|Open |In Progress

--- Comment #3 from Lutz Donnerhacke <***@FreeBSD.org> ---
Please test this patch: https://reviews.freebsd.org/D30110
--
You are receiving this mail because:
You are on the CC list for the bug.
b***@freebsd.org
2021-06-04 09:22:36 UTC
Permalink
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241954

--- Comment #4 from commit-***@FreeBSD.org ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=0345fd891fe13a191fc0fae9463ea9458bfaff5a

commit 0345fd891fe13a191fc0fae9463ea9458bfaff5a
Author: Lutz Donnerhacke <***@FreeBSD.org>
AuthorDate: 2021-05-04 19:20:39 +0000
Commit: Lutz Donnerhacke <***@FreeBSD.org>
CommitDate: 2021-06-04 09:20:19 +0000

netgraph/ng_base: Renaming a node to the same name is a noop

Detailed analysis in
https://github.com/genneko/freebsd-vimage-jails/issues/2
brought the problem down to a double call of ng_node_name() before and
after a vnet move. Because the name of the node is already known
(occupied by itself), the second call fails.

PR: 241954
Reported by: Paul Armstrong
MFC: 1 week
Differential Revision: https://reviews.freebsd.org/D30110

sys/netgraph/ng_base.c | 4 ++++
1 file changed, 4 insertions(+)
--
You are receiving this mail because:
You are on the CC list for the bug.
b***@freebsd.org
2021-06-04 09:23:50 UTC
Permalink
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241954

Lutz Donnerhacke <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|In Progress |Closed
--
You are receiving this mail because:
You are on the CC list for the bug.
b***@freebsd.org
2021-06-04 09:25:38 UTC
Permalink
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241954

Lutz Donnerhacke <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Flags| |mfc-stable13?,
| |mfc-stable12?,
| |mfc-stable11?
--
You are receiving this mail because:
You are on the CC list for the bug.
b***@freebsd.org
2021-06-05 00:05:32 UTC
Permalink
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241954

Kubilay Kocak <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|netgraph fails on |netgraph: Fails on
|concurrent node rename |concurrent node rename
URL| |https://reviews.freebsd.org
| |/D30110
See Also| |https://github.com/genneko/
| |freebsd-vimage-jails/issues
| |/2

--- Comment #5 from Kubilay Kocak <***@FreeBSD.org> ---
^Triage: Re-open pending merges
--
You are receiving this mail because:
You are on the CC list for the bug.
Loading...