[Bug 220468] libfetch: Does not handle 407 (proxy auth) when connecting to HTTPS using connect tunnel

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220468

--- Comment #14 from Renato Botelho <***@FreeBSD.org> ---
I just want to note that this bug still happens and this patch still works. We
added it to pfSense to fix a problem reported by our users

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220468

Kubilay Kocak <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Assignee|***@FreeBSD.org |***@FreeBSD.org
Flags| |mfc-stable13?
Keywords|needs-qa |

--- Comment #16 from Kubilay Kocak <***@FreeBSD.org> ---
(In reply to commit-hook from comment #15)

Is this targeted for releng/13 and stable/* ? That would be lovely.

^Triage: Assign to committer resolving

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220468

--- Comment #15 from commit-***@FreeBSD.org ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=345c30a94f6425954163f1e0b075a75f603d27cd

commit 345c30a94f6425954163f1e0b075a75f603d27cd
Author: Renato Botelho <***@FreeBSD.org>
AuthorDate: 2021-04-01 21:02:57 +0000
Commit: Renato Botelho <***@FreeBSD.org>
CommitDate: 2021-04-01 21:02:57 +0000

libfetch: Retry with proxy auth when server returns 407

PR: 220468
Submitted by: Egil Hasting <***@higen.org> (based on)
Reviewed by: kevans, kp
Approved by: kp
MFC after: 2 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")
Differential Revision: https://reviews.freebsd.org/D29533

lib/libfetch/http.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++------
1 file changed, 49 insertions(+), 6 deletions(-)

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220468

Renato Botelho <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|Open |In Progress

--- Comment #17 from Renato Botelho <***@FreeBSD.org> ---
(In reply to Kubilay Kocak from comment #16)
It's too late for releng/13.0, we already have an RC5. I plan to merge it to
all supported stable branches

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220468

--- Comment #18 from Kubilay Kocak <***@FreeBSD.org> ---
(In reply to Renato Botelho from comment #17)

^Triage: Thanks, please include PR: references in those merges :)

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220468

--- Comment #19 from commit-***@FreeBSD.org ---
A commit in branch stable/13 references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=d7682961d386ebc7d5ec9cb38e609d3ec9bb978a

commit d7682961d386ebc7d5ec9cb38e609d3ec9bb978a
Author: Renato Botelho <***@FreeBSD.org>
AuthorDate: 2021-04-01 21:02:57 +0000
Commit: Renato Botelho <***@FreeBSD.org>
CommitDate: 2021-04-28 19:21:26 +0000

libfetch: Retry with proxy auth when server returns 407

PR: 220468
Submitted by: Egil Hasting <***@higen.org> (based on)
Reviewed by: kevans, kp
Approved by: kp
MFC after: 2 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")
Differential Revision: https://reviews.freebsd.org/D29533

(cherry picked from commit 345c30a94f6425954163f1e0b075a75f603d27cd)

lib/libfetch/http.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++------
1 file changed, 49 insertions(+), 6 deletions(-)

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220468

--- Comment #20 from commit-***@FreeBSD.org ---
A commit in branch stable/12 references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=208c36a005f5592a9f3325036cd2e6f6ee03ca9a

commit 208c36a005f5592a9f3325036cd2e6f6ee03ca9a
Author: Renato Botelho <***@FreeBSD.org>
AuthorDate: 2021-04-01 21:02:57 +0000
Commit: Renato Botelho <***@FreeBSD.org>
CommitDate: 2021-04-28 19:31:27 +0000

libfetch: Retry with proxy auth when server returns 407

PR: 220468
Submitted by: Egil Hasting <***@higen.org> (based on)
Reviewed by: kevans, kp
Approved by: kp
MFC after: 2 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")
Differential Revision: https://reviews.freebsd.org/D29533

(cherry picked from commit 345c30a94f6425954163f1e0b075a75f603d27cd)

lib/libfetch/http.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++------
1 file changed, 49 insertions(+), 6 deletions(-)

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220468

Renato Botelho <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Flags|mfc-stable13?, |mfc-stable13+,
|mfc-stable12?, |mfc-stable12+,
|mfc-stable11? |mfc-stable11-
Status|In Progress |Closed