[Bug 218579] Wake on Lan doesn't work for bge NIC driver

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218579

--- Comment #8 from Koen Martens <***@metro.cx> ---
(In reply to Cy Schubert from comment #6)
Hi, thanks for the reply (and the reworked patch). I guess the patch won't go
upstream because of the reasons mentioned (ie. potential to blow up boards that
can't support enough power when the system is powered down)?

I'm also surprised it did work for me. I actually woke up the machine with
wake-on-lan to ssh into it and upgrade it to 11.1-RELEASE.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218579

--- Comment #9 from Cy Schubert <***@FreeBSD.org> ---
(In reply to Koen Martens from comment #8)
That bug has been fixed in the latest patch I posted here. No worries about
drawing too much current when powered off any more.

I've been using it and previous versions of this patch on my laptop (only
machine I have with bge) for about a year.

I suppose I should submit the patch in phabricator for review prior to commit.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218579

NK <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com

--- Comment #10 from NK <***@gmail.com> ---
There still have issue with WOL patch for bge driver on FreeBSD 11.2.

It seems there is boot issues, see here:
https://www.xigmanas.com/forums/viewtopic.php?f=78&t=13807#p85480

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218579

Mark Linimon <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Version|CURRENT |11.2-STABLE

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218579

--- Comment #11 from Cy Schubert <***@FreeBSD.org> ---
(In reply to NK from comment #10)
Sketchy details. There's nothing to go on.

The WOL patch was developed for 12-CURRENT only. The only issue is a system
will not halt -p after being woken by WOL, but will after a reboot.

I'll try to port it back to 11-STABLE if anyone is interested.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218579

--- Comment #12 from ***@gmx.de ---
(In reply to Cy Schubert from comment #11)
I would very much appreciate it. Thanks a lot for your efforts!

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218579

--- Comment #13 from Cy Schubert <***@FreeBSD.org> ---
Created attachment 197700
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=197700&action=edit
WOL patch for stable/11

Same patch, for stable/11. I haven't tried to build or use this particular
patch on stable/11. However a previous version was developed for current/11 at
the time. This patch has the same problem as the -CURRENT patch, the system
will reboot on halt -p the first time around. I'm not sure of the solution for
this yet.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218579

George B <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com

--- Comment #14 from George B <***@gmail.com> ---
I had 11.1 patched with https://github.com/NamTaf/if_bge_wol and it worked
can I apply the same patch on 11.2 p4 ?
I only need this for WOL.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218579

tony <***@outlook.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@outlook.com

--- Comment #18 from tony <***@outlook.com> ---
Hy guys,

Can anyone explain me how to patch the driver? I cannot find the file if_bge.c
anywhere...
is there a way to make it to one of the next version? this would be really
appreciated!

Best

Tony

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218579

--- Comment #19 from Chris Hutchinson <***@bsdforge.com> ---
(In reply to tony from comment #18)

Post by b***@freebsd.org
Can anyone explain me how to patch the driver?

copy your choice of one of the 2 attached diff files
to /usr/src.
# cd /usr/src
# patch < your-chosen-diff-file
Done.
see man diff && man patch for greater detail(s). :-)

Post by b***@freebsd.org
I cannot find the file if_bge.c anywhere...

# cd /usr/src
# find . -type f -name if_bge.c

Post by b***@freebsd.org
is there a way to make it to one of the next version?
this would be really appreciated!

HTH

--Chris

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218579

--- Comment #20 from Cy Schubert <***@FreeBSD.org> ---
(In reply to Chris Hutchinson from comment #19)
The latest patch is for 14-CURRENT. It works here except for a bug which I
cannot track down. The bug is that after waking the machine the next time you
do a halt -p the machine will reboot if the machine hasn't been rebooted using
reboot in the mean time. It appears that some kind of status bit has been set
in the NIC that when the machine powers itself off the first time after being
woken it powers itself back on again. Only that once and only if there haven't
been any reboots prior to that.

Otherwise this patch would have been committed long ago.

Please apply the patch and let me know if you experience this or if it is
simply my laptop that has this problem. (My laptop doesn't experience this when
booted from Windows 10 or Fedora, only with the patch I cobbled up for
FreeBSD.)