fib[46]_lookup_rt usage in netflow.c, sa_len comparison with AF_INET

[Guy Yur]

Hi,

I was looking for examples on how to use fib6_lookup_rt and noticed
there are comparisons between sa_len and AF_ flags in netflow.c
if (nh->gw_sa.sa_len == AF_INET)
if (nh->gw_sa.sa_len == AF_INET6)

Are these typos for sa_family?

https://cgit.freebsd.org/src/tree/sys/netgraph/netflow/netflow.c#n363
https://cgit.freebsd.org/src/tree/sys/netgraph/netflow/netflow.c#n437

Added in
https://cgit.freebsd.org/src/commit/sys/netgraph/netflow/netflow.c?id=4e19e0d92ac6dfa5d2df6d525922f1e60487a9cc


Thanks,
Guy Yur

[Hans Petter Selasky]

Post by Guy Yur
Hi,
I was looking for examples on how to use fib6_lookup_rt and noticed
there are comparisons between sa_len and AF_ flags in netflow.c
if (nh->gw_sa.sa_len == AF_INET)
if (nh->gw_sa.sa_len == AF_INET6)
Are these typos for sa_family?

Hi,

According to:

sys/net/route/nhop.c

Yes. Should both be sa_family.

--HPS

Post by Guy Yur
https://cgit.freebsd.org/src/tree/sys/netgraph/netflow/netflow.c#n363
https://cgit.freebsd.org/src/tree/sys/netgraph/netflow/netflow.c#n437
Added in
https://cgit.freebsd.org/src/commit/sys/netgraph/netflow/netflow.c?id=4e19e0d92ac6dfa5d2df6d525922f1e60487a9cc

--HPS